Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#27057 EDocument Connector for Tietoevry #27233 #27626

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

#27057 EDocument Connector for Tietoevry #27233 #27626

wants to merge 21 commits into from

Conversation

Roglar01
Copy link

@Roglar01 Roglar01 commented Nov 13, 2024 •
edited by github-actions bot
Loading

E-Documents connector interface implementation between Business Central and Tietoevry

Work Item(s)
Fixes #27057
Fixes AB#541808

@Roglar01 Roglar01 requested a review from a team as a code owner November 13, 2024 12:47
@Roglar01 Roglar01 requested a review from VDTemp November 13, 2024 12:47
@Roglar01 Roglar01 mentioned this pull request Nov 13, 2024
Open
1 task
@github-actions github-actions bot added the linked Issue is linked to a Azure Boards work item label Nov 13, 2024
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Nov 14, 2024
@microsoft microsoft deleted a comment from github-actions bot Nov 20, 2024
Groenbech96
Groenbech96 requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New interface will break build as we discussed. The filenames do not follow code convention :)

@Roglar01
Copy link
Author

@Groenbech96 I know. Work in progress here. Will update next week.

Groenbech96
Groenbech96 requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, good start. Will review further later.

Apps/W1/EDocumentConnectors/Tietoevry/app/src/ConnectionSetup.Table.al Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/ConnectionSetupCard.Page.al Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Upgrade.Codeunit.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/IntegrationImpl.Codeunit.al Outdated Show resolved Hide resolved
@Groenbech96
Copy link
Contributor

Error: AA0215 The file Objects.PermissionSet.al has an incorrect name. The valid name is TietoevryObjects.PermissionSet.al.
Error: AA0215 The file Read.PermissionSet.al has an incorrect name. The valid name is TietoevryRead.PermissionSet.al.
Error: AA0215 The file Edit.PermissionSet.al has an incorrect name. The valid name is TietoevryEdit.PermissionSet.al.
Error: AA0215 The file TeitoevryEDocConnectorEdit.PermissionSetExt.al has an incorrect name. The valid name is TietoevryEDocConnectorEdit.PermissionSetExt.al.
Error: AA0215 The file EDocFormat.EnumExt.al has an incorrect name. The valid name is EDocFormatExt.EnumExt.al.
Error: AA0215 The file EDocumentImpl.al has an incorrect name. The valid name is TietoevryEDocument.Codeunit.al.
Error: AA0215 The file Cod6398.FormatEvents.al has an incorrect name. The valid name is FormatEvents.Codeunit.al.
Error: AA0215 The file TietoevryEDocImport.al has an incorrect name. The valid name is TietoevryEDocumentImport.Codeunit.al.
Error: AA0137 Variable 'EDocumentAttachmentGen' is unused in '"Tietoevry E-Document Import"'.
Error: AA0137 Variable 'EDocument' is unused in 'ParseCreditMemo'.
Error: AA0137 Variable 'EDocument' is unused in 'ParseInvoice'.

@Roglar01
Copy link
Author

In file /Formats/TietoevryEDocImport.Codeunit I have an issue with the fact that the protection level on EDocumentAttachmentGen.Insert() procedure makes me unable to use it from this app. Can you consider changing the protection level (from internal to public), allowing me to complete the format implementation without duplicating code? "pragma warning disable AA0137" is there to suppress all warnings related to this. @Groenbech96

Groenbech96
Groenbech96 requested changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@Groenbech96 Groenbech96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull the commit i made above.
Left comments on the rest.

Apps/W1/EDocumentConnectors/Tietoevry/app/src/Formats/TietoevryEDocImport.Codeunit.al Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Extensions/EDocFormat.EnumExt.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Extensions/EDocument.TableExt.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Extensions/EDocument.TableExt.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Extensions/EDocument.TableExt.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/HttpExecutor.Codeunit.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/HttpExecutor.Codeunit.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/HttpExecutor.Codeunit.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Integration.EnumExt.al Outdated Show resolved Hide resolved
Apps/W1/EDocumentConnectors/Tietoevry/app/src/Requests.Codeunit.al Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groenbech96 Groenbech96 Groenbech96 requested changes

@VDTemp VDTemp Awaiting requested review from VDTemp VDTemp is a code owner automatically assigned from microsoft/dynamics-365-business-central

Requested changes must be addressed to merge this pull request.

Assignees

@Groenbech96 Groenbech96

Labels
Integration GitHub request for Integration area linked Issue is linked to a Azure Boards work item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Enable connector with Tietoevry for E-Documents
3 participants
@Roglar01 @Groenbech96 @JesperSchulz